Remove obsolete check for TTSOpsVirtual from slot_compile_deform

From: Xing Guo <higuoxing(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Remove obsolete check for TTSOpsVirtual from slot_compile_deform
Date: 2023-10-30 14:58:49
Message-ID: CACpMh+Awj2OoKVB3TMyz=qu9Q=ONNDum=XmhsGUXJPtkXgk4cQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi hackers,

While exploring the JIT support for tuple deforming process, I noticed that
one check for TTSOpsVirtual in slot_compile_deform is obsolete. Since
virtual tuples never need deforming and there's an assertion in
llvm_compile_expr[1]. I simply replace it with an assertion in
slot_compile_deform. Patch is attached.

[1]
https://github.com/postgres/postgres/blob/0c60e8ba80e03491b028204a19a9dca6d216df91/src/backend/jit/llvm/llvmjit_expr.c#L322

Best Regards,
Xing

Attachment Content-Type Size
v1-0001-Remove-obsolete-check-for-TTSOpsVirtual-from-slot.patch text/x-patch 1.2 KB

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2023-10-30 15:20:06 Re: Memory consumed by child SpecialJoinInfo in partitionwise join planning
Previous Message Stephen Frost 2023-10-30 14:46:11 Re: Fwd: Annoying corruption in PostgreSQL.