| From: | Xing Guo <higuoxing(at)gmail(dot)com> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: JIT: Remove some unnecessary instructions. |
| Date: | 2024-09-02 02:23:49 |
| Message-ID: | CACpMh+AGeYwVLuQUWiQrFvCdF-+q00QZ0OQrPoitmZveztuVsg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 30, 2024 at 8:50 PM Andreas Karlsson <andreas(at)proxel(dot)se> wrote:
>
> On 8/30/24 5:55 AM, Xing Guo wrote:
> > I find there are some unnecessary load/store instructions being
> > emitted by the JIT compiler.
>
> Well spotted! All of these are obvious dead instructions and while LLVM
> might be able to optimize them away there is no reason to create extra
> work for the optimizer.
>
> The patch looks good, applies and the tests passes.
Thanks for testing it! I spotted another unnecessary store instruction
and added it in my V2 patch.
Best Regards,
Xing
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-JIT-Remove-unnecessary-load-store-instructions.patch | text/x-patch | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andy Fan | 2024-09-02 03:18:23 | Re: Make printtup a bit faster |
| Previous Message | Michael Paquier | 2024-09-02 01:11:43 | Re: query_id, pg_stat_activity, extended query protocol |