| From: | Paul Ramsey <pramsey(at)cleverelephant(dot)ca> |
|---|---|
| To: | rafia(dot)sabih(at)enterprisedb(dot)com |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Compressed TOAST Slicing |
| Date: | 2018-12-06 20:54:18 |
| Message-ID: | CACowWR2qvuG88JuYAqbAeD4VtN6CtXucqEGReBapr2Dbev_mUw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Dec 2, 2018 at 7:03 AM Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com>
wrote:
>
> The idea looks good and believing your performance evaluation it seems
> like a practical one too.
Thank you kindly for the review!
> A comment explaining how this check differs for is_slice case would be
helpful.
> Looks like PG indentation is not followed here for n.
I have attached updated patches that add the comment and adhere to the Pg
variable declaration indentation styles,
ATB!
P
--
Paul Ramsey
http://crunchydata.com
| Attachment | Content-Type | Size |
|---|---|---|
| compressed-datum-slicing-left-20190103a.patch | application/octet-stream | 956 bytes |
| compressed-datum-slicing-20190103a.patch | application/octet-stream | 5.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2018-12-06 21:50:11 | Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock |
| Previous Message | Alexander Korotkov | 2018-12-06 20:51:38 | Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock |