| From: | Kevin Grittner <kgrittn(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Kevin Grittner <kgrittn(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Modify BufferGetPage() to prepare for "snapshot too old" feature |
| Date: | 2016-08-24 18:00:40 |
| Message-ID: | CACjxUsPOm-cGPdG7_XpPQ_jLPhz7dqqphuOO5aqsvZ6iM4qdQQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Aug 24, 2016 at 12:40 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Kevin Grittner wrote:
>> Modify BufferGetPage() to prepare for "snapshot too old" feature
>
> I just noticed that this commit added a line to #include catalog/catalog.h
> in storage/bufmgr.h. I can't find any reason for it doing so, and I
> think it's a bad line to have there. Can we get it removed?
Will do that now. It was initially added because
IsCatalogRelation() was referenced in storage/bufmgr.h, but for
various reasons it seemed better to move that, and I missed the
include. Thanks for spotting it.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2016-08-24 18:22:17 | pgsql: Remove unnecessary #include. |
| Previous Message | Alvaro Herrera | 2016-08-24 17:40:17 | Re: [COMMITTERS] pgsql: Modify BufferGetPage() to prepare for "snapshot too old" feature |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-08-24 18:16:12 | Re: Write Ahead Logging for Hash Indexes |
| Previous Message | Artur Zakirov | 2016-08-24 17:42:25 | Re: Bug in to_timestamp(). |