| From: | Kevin Grittner <kgrittn(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Snapshot too old logging |
| Date: | 2016-11-15 16:20:39 |
| Message-ID: | CACjxUsNpNWoumWMxR9ppPNkvOHib406TkorkfMerDv2rLm0Mbw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 15, 2016 at 3:38 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Is there a reason why we don't log which relation triggered the snapshot too
> old error when it happens?
>
> Since we do have Relation available in TestForOldSnapshot_impl(), shouldn't
> we be able to include it?
>
> Having that in the log message would be very helpful, but is there a reason
> why it wouldn't work?
I would probably not want to mess with the text of the error
itself, in case any client-side software bases recovery on that
rather than the SQLSTATE value; but including relation (and maybe
the timestamp on the snapshot?) in detail or context portions seems
like a great idea.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2016-11-15 16:25:01 | Re: proposal: psql \setfileref |
| Previous Message | Magnus Hagander | 2016-11-15 15:53:41 | jsonb_delete with arrays |