| From: | Kevin Grittner <kgrittn(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>, Sehrope Sarkuni <sehrope(at)jackdb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [REVIEW] Tab Completion for CREATE DATABASE ... TEMPLATE ... |
| Date: | 2016-09-12 13:14:26 |
| Message-ID: | CACjxUsMxmXL4BO-1RuP6_HNO5eA+7exFpW6ehUqK6wbB3zi0kg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 12, 2016 at 7:55 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Kevin Grittner <kgrittn(at)gmail(dot)com> writes:
>> But that gives incorrect results for the case I asked about earlier
>> on the thread, while the query I pushed gives correct results:
>
> AFAICS, my query gives correct results for that case. bob is permitted
> to copy fred's databases db1 and postgres, or would be if he had createdb
> privileges. The query you committed is flat wrong, because it doesn't
> account for database ownership being granted via role membership.
Ah, there was a flaw in my testing script. It appeared from my
(flawed) testing that the inherited ownership wasn't enough to
allow use as a template. With the script fixed I see that it does.
Sorry for the noise. Will fix.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= | 2016-09-12 13:16:52 | Re: [PATCH] Tab completion for ALTER TYPE … RENAME VALUE … |
| Previous Message | Tom Lane | 2016-09-12 12:55:28 | Re: [REVIEW] Tab Completion for CREATE DATABASE ... TEMPLATE ... |