Re: TestForOldSnapshot() seems to be in the wrong place

From: Kevin Grittner <kgrittn(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: TestForOldSnapshot() seems to be in the wrong place
Date: 2019-01-22 14:46:59
Message-ID: CACjxUsMY4-mnW72fTC3yW0R0beEL5vEpj+OaPUEAb__V=NcGTw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 18, 2019 at 3:13 PM Andres Freund <andres(at)anarazel(dot)de> wrote:

> TestForOldSnapshot()

> to me it seems wrong from a layering POV to have this in
> bufmgr.[ch]. Due to the inline functions this makes bufmgr.h have a
> dependency on snapmgr.h and tqual.h, which to me seems wrong from a
> layer POV. Why isn't this declared in snapmgr.h or a new header file?

I will take a look.

--
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-01-22 15:07:27 Re: Rare SSL failures on eelpout
Previous Message David Rowley 2019-01-22 14:43:35 Re: [HACKERS] PATCH: multivariate histograms and MCV lists