| From: | Kevin Grittner <kgrittn(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, Kevin Grittner <kgrittn(at)ymail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Khandekar <amit(dot)khandekar(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: delta relations in AFTER triggers |
| Date: | 2017-03-31 16:06:31 |
| Message-ID: | CACjxUsMOj4rzj6XQH_9=AG7b96UuWFs2mv=pOyc1n+FN8aV3kA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 23, 2017 at 7:14 PM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> my only other comment would be a bikeshed issue:
> Enr isn't a great name for a struct.
I know, but EphemeralNamedRelation starts to get kinda long,
especially when making the normal sorts of concatenations. I
started making the change and balked when I saw things like
EphemeralNamedRelationMetadataData and a function named
EphemeralNamedRelationMetadataGetTupDesc() in place of
EnrmdGetTupDesc(). A 40 character function name make for a lot of
line-wrapping to stay within pgindent limits. Any suggestions?
--
Kevin Grittner
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2017-03-31 16:06:35 | Re: [bug fix] Savepoint-related statements terminates connection |
| Previous Message | Ashutosh Sharma | 2017-03-31 16:01:42 | Re: PATCH: pageinspect / add page_checksum and bt_page_items(bytea) |