| From: | Kevin Grittner <kgrittn(at)gmail(dot)com> |
|---|---|
| To: | Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>, Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, Jason Dusek <jason(dot)dusek(at)gmail(dot)com>, "pgsql-general(at)postgresql(dot)org" <pgsql-general(at)postgresql(dot)org> |
| Subject: | Re: SERIALIZABLE and INSERTs with multiple VALUES |
| Date: | 2016-10-12 19:45:27 |
| Message-ID: | CACjxUsM+0jL4ajXsdVP4PB-wg2rupYw_pzMVsM-EauFRWYrZZg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general |
On Wed, Oct 12, 2016 at 10:06 AM, Kevin Grittner <kgrittn(at)gmail(dot)com> wrote:
> The test in ExecCheckHeapTupleVisible() seems wrong to me. It's
> not immediately obvious what the proper fix is.
To identify what cases ExecCheckHeapTupleVisible() was meant to
cover I commented out the body of the function to see which
regression tests failed. None did. The failures shown on this
thread are fixed by doing so. If there is really a need for this
function, speak up now and provide a test case showing what is
broken without it; otherwise if I can't find some justification for
this function I will rip it (and the calls to it) out of the code.
If you do have some test case showing what breaks without the
function, let's get it added to the regression tests!
I'm currently running `make check-world` with TAP tests enabled,
just in case there is some test there which demonstrates the need
for this. It seems unlikely that such a test would be under the
TAP tests, but I'm making sure...
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2016-10-12 20:02:40 | Re: SERIALIZABLE and INSERTs with multiple VALUES |
| Previous Message | arnaud gaboury | 2016-10-12 15:57:58 | Re: confusion about user paring with pg_hba and pg_ident |