| From: | Karina Litskevich <litskevichkarina(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_stat_statements: Avoid holding excessive lock |
| Date: | 2024-11-07 13:08:30 |
| Message-ID: | CACiT8ia7ya4DVxZ3w-Jx4M7LwPNdaAXVf99E5LCYHq+cSXZXxg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 7, 2024 at 11:17 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> The comment could be simpler, say a "The spinlock is not required when
> reading these two as they are always updated when holding pgss->lock
> exclusively.". Or something like that.
Thank you for your feedback and the shorter wording of the comment.
I used it in the new version of the patch.
Best regards,
Karina Litskevich
Postgres Professional: http://postgrespro.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-pg_stat_statements-Avoid-excessive-lock-holding.patch | text/x-patch | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vitaly Davydov | 2024-11-07 13:30:39 | Re: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly |
| Previous Message | Peter Eisentraut | 2024-11-07 12:15:45 | Re: altering a column's collation leaves an invalid foreign key |