| From: | Atsushi Torikoshi <atorik(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: add types to index storage params on doc |
| Date: | 2020-03-16 07:50:32 |
| Message-ID: | CACZ0uYFvHF4n6yxF390YZgr4Q0Z0c2w0ihu=DLb8ipNOnNcqzQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for your comments!
On Mon, Mar 16, 2020 at 11:49 AM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
wrote:
> - <term><literal>buffering</literal>
> + <term><literal>buffering</literal> (<type>string</type>)
>
> Isn't it better to use "enum" rather than "string"?
> In the docs about enum GUC parameters, "enum" is used there.
>
Agreed. I've fixed it to "enum".
But I'm now wondering about the type of check_option[3], [4].
Because I decide the type to "string" referring to check_option, which is
the other element of enumRelOpts in reloptions.c.
Should I also change it to "enum"?
[3]https://www.postgresql.org/docs/devel/sql-alterview.html#id-1.9.3.45.6
[4]https://www.postgresql.org/docs/devel/sql-createview.html#id-1.9.3.97.6
Regards,
--
Torikoshi Atsushi
| Attachment | Content-Type | Size |
|---|---|---|
| add_type_in_createindex_storage-params_v2.patch | application/octet-stream | 3.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2020-03-16 07:54:46 | Re: Berserk Autovacuum (let's save next Mandrill) |
| Previous Message | Masahiko Sawada | 2020-03-16 07:13:21 | Re: Internal key management system |