| From: | Ayush Vatsa <ayushvatsa1810(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, michael(at)paquier(dot)xyz |
| Subject: | Re: Pgstattuple on Sequences: Seeking Community Feedback on Potential Patch |
| Date: | 2024-08-29 18:47:47 |
| Message-ID: | CACX+KaM3Kk-mEUm4E_iLa5AXGKnhAa5QT6odPDRFeSeadr27ag@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I'm concerned that some of this might be platform-dependent and make the
> test unstable. Perhaps we should just select count(*) here.
> Sure enough, the CI testing for 32-bit is failing here [0].
Thanks for catching that! I wasn't aware of this earlier.
> I think we should be a bit more descriptive here
Regarding the comment, I've tried to make it more
descriptive and simpler than the existing one in
verify_heapam.c. Here’s the comment I propose:
/*
* Sequences implicitly use the heap AM, even though it's not explicitly
* recorded in the catalogs. For other relation kinds, verify that the AM
* is heap; otherwise, raise an error.
*/
Please let me know if this still isn’t clear enough,
then I can make further revisions in line with verify_heapam.c.
The patch with all the changes is attached.
Regards
Ayush Vatsa
AWS
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Introduced-support-for-sequences-back-in-pgstattu.patch | application/octet-stream | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2024-08-29 18:50:33 | Re: [PATCH] Add CANONICAL option to xmlserialize |
| Previous Message | Pavel Stehule | 2024-08-29 18:17:06 | Re: proposal: schema variables |