Re: Patch to add hook to copydir()

From: Swen Kooij <swenkooij(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Patch to add hook to copydir()
Date: 2019-09-02 19:04:40
Message-ID: CACUs8SuDu1pxs63MQ_j_1Ed783782HJJ=3wbL0re9g8nzi9KhQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I just realized I completely borked the patch file.

My apologies. Attached a (hopefully) correct patch file.

---
Swen Kooij

On Mon, Sep 2, 2019 at 9:54 PM Swen Kooij <swenkooij(at)gmail(dot)com> wrote:
>
> Hello all,
>
> I've been working on an extension that tightly integrates
> postgres with underlying filesystem . I need to customize
> how postgres copies directories for new databases.
>
> I first looked at the ProcessUtility_hook. This would require
> me to copy or rewrite most of the createdb() function. This is
> less than ideal of course. Someone on the IRC channel
> suggested I could add a hook for copydir().
>
> I implemented the hook similar to how the
> ProcessUtility_hook is implemented. I couldn't find any tests
> for any of the existing hooks. I've been looking at the regression
> tests, but I am not entirely sure how to proceed on that front.
>
> I tested my patch extensively against master and
> the REL_12_STABLE branch. All tests pass and the patch has
> been working great with my extension.
>
> I attached a first draft of the patch against master.
>
> ---
> Swen Kooij

Attachment Content-Type Size
copy-dir-hook_v2.patch text/x-patch 2.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2019-09-02 19:18:38 Re: Patch to add hook to copydir()
Previous Message Swen Kooij 2019-09-02 18:54:53 Patch to add hook to copydir()