| From: | Ali Akbar <the(dot)apaan(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Function array_agg(array) |
| Date: | 2014-10-28 00:22:24 |
| Message-ID: | CACQjQLpdm_Jjd4Tca811HKSS+HNRzrye0jCj=nXfkEtuJdku+g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> super
>
> I tested last version and I have not any objections.
>
> 1. We would to have this feature - it is long time number of our ToDo List
>
> 2. Proposal and design of multidimensional aggregation is clean and nobody
> has objection here.
>
> 3. There is zero impact on current implementation. From performance
> reasons it uses new array optimized aggregator - 30% faster for this
> purpose than current (scalar) array aggregator
>
> 4. Code is clean and respect PostgreSQL coding rules
>
> 5. There are documentation and necessary regress tests
>
> 6. Patching and compilation is clean without warnings.
>
> This patch is ready for commit
>
> Thank you for patch
>
Thank you for the thorough review process.
Regards,
--
Ali Akbar
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marti Raudsepp | 2014-10-28 00:22:33 | Re: alter user/role CURRENT_USER |
| Previous Message | Tom Lane | 2014-10-28 00:17:27 | Re: proposal: CREATE DATABASE vs. (partial) CHECKPOINT |