| From: | John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Unhappy about API changes in the no-fsm-for-small-rels patch |
| Date: | 2019-04-25 03:21:21 |
| Message-ID: | CACPNZCtyCJ=xze2L4==TxsaYjJ9Ewbu6vjnF-4CeAmarnxk0=Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 24, 2019 at 1:58 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> The two improvements in this code which are discussed in this thread
> and can be done independently to this patch are:
> a. use one bit to represent each block in the map. This gives us the
> flexibility to use the map for the different threshold for some other
> storage.
> b. improve the usage of smgrexists by checking smgr_fsm_nblocks.
>
> John, can you implement these two improvements either on HEAD or on
> top of this patch?
I've done B in the attached. There is a more recent idea of using the
byte to store the actual free space in the same format as the FSM.
That might be v13 material, but in any case, I'll hold off on A for
now.
--
John Naylor https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| optimize-smgrexists.patch | application/octet-stream | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2019-04-25 06:44:45 | Re: Zedstore - compressed in-core columnar storage |
| Previous Message | Amit Kapila | 2019-04-25 03:20:40 | Re: Unhappy about API changes in the no-fsm-for-small-rels patch |