| From: | John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <akapila(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Avoid creation of the free space map for small heap relations, t |
| Date: | 2019-02-28 02:15:29 |
| Message-ID: | CACPNZCtje4RH_ZFp8pcb4gcGA_7kgAh_LN=Nha6BeC9asrJR+g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Feb 28, 2019 at 7:24 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > The flaw in my thinking was treating extension too similarly too
> > finding an existing block. With your patch clearing the local map in
> > the correct place, it seems the call at hio.c:682 is now superfluous?
>
> What if get some valid block from the first call to
> GetPageWithFreeSpace via local map which has required space? I think
> in that case we will need the call at hio.c:682. Am I missing
> something?
Are you referring to the call at line 393? Then the map will be
cleared on line 507 before we return that buffer.
--
John Naylor https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-02-28 02:40:28 | Re: pgsql: Avoid creation of the free space map for small heap relations, t |
| Previous Message | Michael Paquier | 2019-02-28 02:04:35 | pgsql: Improve documentation of data_sync_retry |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tsunakawa, Takayuki | 2019-02-28 02:15:44 | RE: Protect syscache from bloating with negative cache entries |
| Previous Message | Michael Paquier | 2019-02-28 02:10:14 | Re: Segfault when restoring -Fd dump on current HEAD |