Re: WIP: Avoid creation of the free space map for small tables

On Wed, Jan 16, 2019 at 11:40 AM John Naylor
<john(dot)naylor(at)2ndquadrant(dot)com> wrote:
&gt; On Wed, Jan 16, 2019 at 8:41 AM Amit Kapila
<amit(dot)kapila16(at)gmail(dot)com> wrote:
&gt; &gt; can use a macro for the same? I have changed this in the attached
&gt; &gt; patch, see what you think about it. I have used it at a few other
&gt; &gt; places as well.
&gt;
&gt; The macro adds clarity, so I'm in favor of using it.

It just occured to me that the style FSM_LOCAL_MAP_EXISTS seems more
common for macros that refer to constants, and FSMLocalMapExists for
expressions, but I've only seen a small amount of the code base. Do we
have a style preference here, or is it more a matter of matching the
surrounding code?
</amit(dot)kapila16(at)gmail(dot)com></john(dot)naylor(at)2ndquadrant(dot)com>

--
John Naylor https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services