Re: pg_stat_statements: calls under-estimation propagation

From: Daniel Farina <drfarina(at)acm(dot)org>
To: Peter Geoghegan <peter(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_stat_statements: calls under-estimation propagation
Date: 2012-12-29 13:02:46
Message-ID: CACN56+N60TZOBnF7pJNzomxaGm4iTWH50iBqg3317VqFM+L32g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 29, 2012 at 4:21 AM, Daniel Farina <drfarina(at)acm(dot)org> wrote:
> These were not express goals of the patch, but so long as you are
> inviting features, attached is a bonus patch that exposes the queryid
> and also the notion of a "statistics session" that is re-rolled
> whenever the stats file could not be read or the stats are reset, able
> to fully explain all obvious causes of retrograde motion in
> statistics. It too is cumulative, so it includes the under-estimation
> field. Notably, I also opted to nullify extra pg_stat_statements
> fields when they'd also show "insufficient privileges" (that one is
> spared from this censorship), because I feel as though a bit too much
> information leaks from pg_stat_statement's statistics to ignore,
> especially after adding the query id. Since the common theme here is
> identifying queries, I have called it
> "pg_stat_statements-identification", and it can be found in the git
> repo above under the same name (...-v1).

A small amendment that doesn't really change the spirit of the
narrative is attached.

--
fdr

Attachment Content-Type Size
pg_stat_statements-identification-v2.patch.gz application/x-gzip 6.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-12-29 13:11:00 Re: Event Triggers: adding information
Previous Message Robert Haas 2012-12-29 12:48:36 Re: Event Triggers: adding information