Re: Adding SHOW CREATE TABLE

From: Kirk Wolak <wolakk(at)gmail(dot)com>
To: Jeremy Smith <jeremy(at)musicsmith(dot)net>
Cc: Ron <ronljohnsonjr(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-general <pgsql-general(at)lists(dot)postgresql(dot)org>
Subject: Re: Adding SHOW CREATE TABLE
Date: 2023-05-14 06:20:07
Message-ID: CACLU5mSmZ0hoCbbkGBS7X2jczC8bmP5PE+w=BC=UvAp+36AoBw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Sat, May 13, 2023 at 3:34 PM Jeremy Smith <jeremy(at)musicsmith(dot)net> wrote:

>
>
> On Sat, May 13, 2023, 3:25 AM Kirk Wolak <wolakk(at)gmail(dot)com> wrote:
>
>> Does this imply SQL SYNTAX like:
>>
>> SHOW CREATE TABLE <table_name>
>> [ INCLUDING { ALL | INDEXES | SEQUENCES | ??? }]
>> [EXCLUDING { PK | FK | COMMENTS | STORAGE | } ]
>> [FOR {V11 | V12 | V13 | V14 | V15 }] ??
>> ?
>>
>
> Personally, I would expect a function, like pg_get_tabledef(oid), to match
> the other pg_get_*def functions instead of overloading SHOW. To me, this
> also argues that we shouldn't include indexes because we already have a
> pg_get_indexdef function.
>
> -Jeremy
>
+1

In fact, making it a function will make my life easier for testing, that's
for certain. I don't need to involve the parser,etc. Others can help with
that after the function works.
Thanks for the suggestion!

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Rahul Chordiya 2023-05-14 06:50:58 stop
Previous Message Jeremy Smith 2023-05-13 19:34:44 Re: Adding SHOW CREATE TABLE

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2023-05-14 14:58:37 Re: Should CSV parsing be stricter about mid-field quotes?
Previous Message Greg Stark 2023-05-14 03:11:11 Re: Should CSV parsing be stricter about mid-field quotes?