Re: Pass ParseState as down to utility functions.

On Mon, Dec 16, 2024 at 2:15 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> - likeType = typenameType(NULL, defGetTypeName(likeTypeEl), NULL);
> + likeType = typenameType(pstate, defGetTypeName(likeTypeEl), NULL);
>
> The only test impacted by this change is the CREATE TYPE (LIKE) in
> float8. It seems like this should be separated as a change of its own
> as it impacts its own command.
>
> For the rest, we're just manipulating ATExecAddOf(),
> ATPrepAlterColumnType() and ATExecAlterColumnType(). FWIW, I'm
> feeling annoyed with these new make_parsestate() calls, also knowing
> that we do it twice for the prep and exec parts of AlterColumnType.
> Perhaps that's fine at the end, that's just an increase of calls to
> make_parsestate(), still...
>

I've removed code changes related to ATExecAddOf.
ATPrepAlterColumnType will catch most of the error, so
ATExecAlterColumnType related change is not necessary.

i've split into 3 patches, feel free to merge them in any way.
v12-0001: add error position for ATPrepAlterColumnType.

v12-0002: add error position for these 3 functions:
transformColumnDefinition, transformAlterTableStmt, transformTableConstraint.

v12-0003: add error position for these 2 functions:
DefineType, transformOfType

> > like this command will fail, so we don't need to change
> > create_domain.sgml synopsis section?
>
> Yep, right. I was getting the impression that it would be possible to
> have these ones go through with the parser allowed them when I looked
> at that last Thursday. Will double-check to be sure.
> --
v6-0001-print-out-error-position-for-some-DDL-command.patch
at https://postgr.es/m/CACJufxGQtN2YzecMx=Odk8+kCTeoN7f=M_kM5e05UDW1H1PbkA@mail.gmail.com
have extensive tests.