| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <pg(at)bowt(dot)ie>, "Finnerty, Jim" <jfinnert(at)amazon(dot)com>, Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>, teodor(at)sigaev(dot)ru, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Subject: | Re: POC, WIP: OR-clause support for indexes |
| Date: | 2024-03-09 00:00:00 |
| Message-ID: | CACJufxHWQzjcNT7pKRTJcZL_yQQRiVfsEXsKpJQEe324TgUozA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
+ if (!IsA(lfirst(lc), Invalid))
+ {
+ or_list = lappend(or_list, lfirst(lc));
+ continue;
+ }
Currently `IsA(lfirst(lc)` works.
but is this generally OK? I didn't find any other examples.
do you need do cast, like `(Node *) lfirst(lc);`
If I understand the logic correctly:
In `foreach(lc, args) ` if everything goes well, it will reach
`hashkey.type = T_Invalid;`
which will make `IsA(lfirst(lc), Invalid)` be true.
adding some comments to the above code would be great.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Cary Huang | 2024-03-09 00:16:35 | Re: sslinfo extension - add notbefore and notafter timestamps |
| Previous Message | Daniel Gustafsson | 2024-03-08 23:06:15 | Re: pipe_read_line for reading arbitrary strings |