| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Shayon Mukherjee <shayonj(at)gmail(dot)com> |
| Cc: | Benoit Lobréau <benoit(dot)lobreau(at)gmail(dot)com>, Sami Imseih <samimseih(at)gmail(dot)com>, Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Proposal to Enable/Disable Index using ALTER INDEX (with patch) |
| Date: | 2025-02-03 02:45:43 |
| Message-ID: | CACJufxHROE2pDRYecnts9u12K-2R3AGhFADEw_C-GNiRWKZ6ig@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
hi.
....
modules/test_ddl_deparse/test_ddl_deparse.so.p/test_ddl_deparse.c.o -c
../../Desktop/pg_src/src7/postgres/src/test/modules/test_ddl_deparse/test_ddl_deparse.c
../../Desktop/pg_src/src7/postgres/src/test/modules/test_ddl_deparse/test_ddl_deparse.c:
In function ‘get_altertable_subcmdinfo’:
../../Desktop/pg_src/src7/postgres/src/test/modules/test_ddl_deparse/test_ddl_deparse.c:111:17:
error: enumeration value ‘AT_SetIndexVisible’ not handled in switch
[-Werror=switch]
111 | switch (subcmd->subtype)
| ^~~~~~
../../Desktop/pg_src/src7/postgres/src/test/modules/test_ddl_deparse/test_ddl_deparse.c:111:17:
error: enumeration value ‘AT_SetIndexInvisible’ not handled in switch
[-Werror=switch]
cc1: all warnings being treated as errors
so we need to change test_ddl_deparse.c.
The attached patch fixes the indentation and test_ddl_deparse.c issue.
Maybe we can add some tests on src/test/modules/test_ddl_deparse.
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-minor-indentation-fix.no-cfbot | application/octet-stream | 4.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2025-02-03 02:58:14 | Re: pgbench with partitioned tables |
| Previous Message | Peter Smith | 2025-02-03 00:46:17 | Re: Introduce XID age and inactive timeout based replication slot invalidation |