| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | information_schema.view attgenerated |
| Date: | 2024-09-16 04:12:55 |
| Message-ID: | CACJufxHO3=BA=9S1RAG3=Rp_E=C_ShO9UFfTniEHdMTp4mTS9A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
hi.
one minor issue in src/backend/catalog/information_schema.sql
/*
* 6.22
* COLUMNS view
*/
CREATE VIEW columns ....
CAST(CASE WHEN a.attgenerated = '' THEN pg_get_expr(ad.adbin,
ad.adrelid) END AS character_data) AS column_default,
can change to
CAST(CASE WHEN a.attgenerated = '' AND a.atthasdef THEN
pg_get_expr(ad.adbin, ad.adrelid) END AS character_data) AS
column_default,
CAST(CASE WHEN a.attgenerated <> '' THEN 'ALWAYS' ELSE 'NEVER' END AS
character_data) AS is_generated,
can change to
CAST(CASE WHEN a.attgenerated <> '' AND a.atthasdef THEN 'ALWAYS' ELSE
'NEVER' END AS character_data) AS is_generated,
CAST(CASE WHEN a.attgenerated <> '' THEN pg_get_expr(ad.adbin,
ad.adrelid) END AS character_data) AS generation_expression,
can change to
CAST(CASE WHEN a.attgenerated <> '' AND a.atthasdef THEN
pg_get_expr(ad.adbin, ad.adrelid) END AS character_data) AS
generation_expression,
i guess, it will have some minor speed up, also more accurate.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-09-16 05:09:24 | Re: Regression tests fail with tzdata 2024b |
| Previous Message | Amit Kapila | 2024-09-16 03:25:10 | Re: Introduce XID age and inactive timeout based replication slot invalidation |