Re: UniqueKey v2

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: zhihuifan1213(at)163(dot)com
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: UniqueKey v2
Date: 2023-10-16 05:09:43
Message-ID: CACJufxHNn27N5uRSU64TBFqFAMf0HEVzNGz6yB-JMFQZnT0T0g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

hi.
After `git am`, I still cannot build.

../../Desktop/pg_sources/main/postgres/src/backend/optimizer/path/uniquekey.c:125:45:
error: variable ‘var’ set but not used
[-Werror=unused-but-set-variable]
125 | Var *var;
| ^~~

You also need to change src/backend/optimizer/path/meson.build.

git apply failed.

git am warning:
Applying: uniquekey on base relation and used it for mark-distinct-as-op.
.git/rebase-apply/patch:876: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

I think you can use `git diff --check`
(https://git-scm.com/docs/git-diff) to check for whitespace related
errors.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2023-10-16 05:50:51 Re: Add support for AT LOCAL
Previous Message Hayato Kuroda (Fujitsu) 2023-10-16 05:03:16 RE: pg_upgrade's interaction with pg_resetwal seems confusing