pg_dumpall appendPQExpBuffer construct sql need an white space

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: pg_dumpall appendPQExpBuffer construct sql need an white space
Date: 2025-01-16 02:53:51
Message-ID: CACJufxGkvhD_S9hGium08MCVqKqpreyq01NzDqajqYJ=R+xg2Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

hi.

in src/bin/pg_dump/pg_dumpall.c
appendPQExpBuffer(buf, " FROM pg_auth_members a "
"LEFT JOIN %s ur on ur.oid = a.roleid "
"LEFT JOIN %s um on um.oid = a.member "
"LEFT JOIN %s ug on ug.oid = a.grantor "
"WHERE NOT (ur.rolname ~ '^pg_' AND um.rolname ~ '^pg_')"
"ORDER BY 1,2,4", role_catalog, role_catalog,
role_catalog);

here "WHERE NOT (ur.rolname ~ '^pg_' AND um.rolname ~ '^pg_')"
need a white space at the end?

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-01-16 02:59:59 Re: pg_dumpall appendPQExpBuffer construct sql need an white space
Previous Message Noah Misch 2025-01-16 02:47:32 Re: Issue with markers in isolation tester? Or not?