| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, zhjwpku(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add new COPY option REJECT_LIMIT |
| Date: | 2024-10-03 07:27:19 |
| Message-ID: | CACJufxGKKSc7ctga8+2ZijHdjnKu2arxrLHqBmoF7AVysex6Cw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I'm wondering if we can use the wording maxerror as in the attached
> patch.
>
+ <varlistentry>
+ <term><literal>REJECT_LIMIT</literal></term>
+ <listitem>
+ <para>
+ Specifies the maximum number of errors tolerated while converting a
+ column's input value to its data type, when
<literal>ON_ERROR</literal> is
+ set to <literal>ignore</literal>.
+ If the input causes more errors than the specified value, the
<command>COPY</command>
+ command fails, even with <literal>ON_ERROR</literal> set to
<literal>ignore</literal>.
+ This clause must be used with
<literal>ON_ERROR</literal>=<literal>ignore</literal>
+ and <replaceable class="parameter">maxerror</replaceable> must
be positive.
+ If not specified, <literal>ON_ERROR</literal>=<literal>ignore</literal>
+ allows an unlimited number of errors, meaning
<command>COPY</command> will
+ skip all erroneous data.
+ </para>
+ </listitem>
+ </varlistentry>
mentioning <replaceable class="parameter">maxerror</replaceable> is a
bigint type
or explicitly mentioning the maximum allowed value of "maxerror" would be great.
other than that, it looks good to me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Kuznetsov | 2024-10-03 07:47:40 | [PATCH] Check for TupleTableSlot nullness before dereferencing |
| Previous Message | jian he | 2024-10-03 07:16:43 | Re: not null constraints, again |