| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Himanshu Upadhyaya <upadhyaya(dot)himanshu(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: remaining sql/json patches |
| Date: | 2024-04-08 05:01:47 |
| Message-ID: | CACJufxGB9wC0K4yTxo8xmGrkPRW-M6TMA5V+rpKsxgHwJ7+NKg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 8, 2024 at 11:21 AM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> On Mon, Apr 8, 2024 at 12:34 AM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> >
> > On Sun, Apr 7, 2024 at 9:36 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > > 0002 needs an expanded commit message but I've run out of energy today.
> > >
>
> other than that, it looks good to me.
one more tiny issue.
+EXPLAIN (COSTS OFF, VERBOSE) SELECT * FROM jsonb_table_view1;
+ERROR: relation "jsonb_table_view1" does not exist
+LINE 1: EXPLAIN (COSTS OFF, VERBOSE) SELECT * FROM jsonb_table_view1...
+ ^
maybe you want
EXPLAIN (COSTS OFF, VERBOSE) SELECT * FROM jsonb_table_view7;
at the end of the sqljson_jsontable.sql.
I guess it will be fine, but the format json explain's out is quite big.
you also need to `drop table s cascade;` at the end of the test?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2024-04-08 05:02:58 | Re: Extension Enhancement: Buffer Invalidation in pg_buffercache |
| Previous Message | Masahiko Sawada | 2024-04-08 04:58:55 | Re: Improve tab completion for ALTER DEFAULT PRIVILEGE and ALTER TABLE |