Re: Re: proposal: schema variables

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Erik Rijkers <er(at)xs4all(dot)nl>, Michael Paquier <michael(at)paquier(dot)xyz>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, DUVAL REMI <REMI(dot)DUVAL(at)cheops(dot)fr>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Re: proposal: schema variables
Date: 2025-01-05 16:10:37
Message-ID: CACJufxG6tFo1uOtTPoUw0ntzHddahd7EmR37DhsxMXxUixPaeQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-performance

+ /*
+ * The arguments of EXECUTE are evaluated by a direct expression
+ * executor call. This mode doesn't support session variables yet.
+ * It will be enabled later.
+ */
+ if (pstate->p_hasSessionVariables)
+ elog(ERROR, "session variable cannot be used as an argument");

it should be:
/*
* The arguments of CALL statement are evaluated by a direct expression
* executor call. This path is unsupported yet, so block it.
*/
if (pstate->p_hasSessionVariables)
ereport(ERROR,
errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("session variable cannot be used as an argument"));

similarly, EvaluateParams we can change it to
/*
* The arguments of EXECUTE are evaluated by a direct expression
* executor call. This mode doesn't support session variables yet.
* It will be enabled later.
*/
if (pstate->p_hasSessionVariables)
ereport(ERROR,
errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("session variable cannot be used as an argument"));

in src/backend/executor/execExpr.c
we don't need
+#include "catalog/pg_variable.h"
?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2025-01-05 21:52:07 Re: Log a warning in pg_createsubscriber for max_slot_wal_keep_size
Previous Message vignesh C 2025-01-05 12:38:48 Re: Documentation update of wal_retrieve_retry_interval to mention table sync worker

Browse pgsql-performance by date

  From Date Subject
Next Message jian he 2025-01-06 07:58:36 Re: Re: proposal: schema variables
Previous Message jian he 2025-01-05 04:52:15 Re: Re: proposal: schema variables