From: | jian he <jian(dot)universality(at)gmail(dot)com> |
---|---|
To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Erik Rijkers <er(at)xs4all(dot)nl>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: remaining sql/json patches |
Date: | 2024-02-14 00:00:00 |
Message-ID: | CACJufxFqwgz7hR9514npSe2LpE79xXLEMRBJrXXJU6nE-b=yLg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
This part is already committed.
ereport(ERROR,
(errcode(ERRCODE_UNDEFINED_OBJECT),
errmsg("could not find jsonpath variable \"%s\"",
pnstrdup(varName, varNameLength))));
but, you can simply use:
ereport(ERROR,
(errcode(ERRCODE_UNDEFINED_OBJECT),
errmsg("could not find jsonpath variable \"%s\"",varName)));
maybe not worth the trouble.
I kind of want to know, using `pnstrdup`, when the malloc related
memory will be freed?
json_query and json_query doc explanation is kind of crammed together.
Do you think it's a good idea to use </listitem> and </itemizedlist>?
it will look like bullet points. but the distance between the bullet
point and the first text in the same line is a little bit long, so it
may not look elegant.
I've attached the picture, json_query is using `</listitem> and
</itemizedlist>`, json_value is as of the v39.
other than this and previous points, v39, 0001 looks good to go.
Attachment | Content-Type | Size |
---|---|---|
sql_json.png | image/png | 754.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2024-02-14 00:08:03 | Re: Fix incorrect PG_GETARG in pgcrypto |
Previous Message | Tatsuo Ishii | 2024-02-13 23:17:03 | Re: When extended query protocol ends? |