| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | ATExecColumnDefault comments |
| Date: | 2024-09-05 13:50:26 |
| Message-ID: | CACJufxFmLZTzmOV83O2Dd0Buh=HNYtPUs6VAcUGLv+KCWSyqqg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
hi.
one minor issue for ATExecColumnDefault comments.
/*
* ALTER TABLE ALTER COLUMN SET/DROP DEFAULT
*
* Return the address of the affected column.
*/
static ObjectAddress
ATExecColumnDefault(Relation rel, const char *colName,
Node *newDefault, LOCKMODE lockmode)
the comment should be:
* ALTER TABLE ALTER COLUMN SET/DROP DEFAULT
* ALTER VIEW ALTER COLUMN SET/DROP DEFAULT
?
Sometimes, comments are useful for quickly glance at what this function does.
Therefore I guess reword it would be helpful.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-09-05 13:58:36 | Re: updatable view set default interact with base rel generated stored columns |
| Previous Message | Paul A Jungwirth | 2024-09-05 13:45:44 | Re: SQL:2011 application time |