| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Joseph Koshakow <koshy44(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Infinite Interval |
| Date: | 2023-09-21 03:05:26 |
| Message-ID: | CACJufxFfvkO_bxh_JopH3S70MABdOPRqihv1_pSn0WE3gxwESA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Wed, 20 Sept 2023 at 15:00, Ashutosh Bapat
> <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> >
> > 0005 - Refactored Jian's code fixing window functions. Does not
> > contain the changes for serialization and deserialization. Jian,
> > please let me know if I have missed anything else.
> >
attached serialization and deserialization function.
>
> Also, in do_interval_discard(), this seems a bit risky:
>
> + neg_val.day = -newval->day;
> + neg_val.month = -newval->month;
> + neg_val.time = -newval->time;
>
we already have interval negate function, So I changed to interval_um_internal.
based on 20230920 patches. I have made the attached changes.
The serialization do make big difference when configure to parallel mode.
| Attachment | Content-Type | Size |
|---|---|---|
| interval-serialization-and-deserialization-20220921.patch | text/x-patch | 6.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2023-09-21 03:25:12 | CI: Unfamiliar error while testing macOS |
| Previous Message | Lepikhov Andrei | 2023-09-21 02:49:16 | Re: Comment about set_join_pathlist_hook() |