Re: Doc Rework: Section 9.16.13 SQL/JSON Query Functions

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Doc Rework: Section 9.16.13 SQL/JSON Query Functions
Date: 2024-07-09 01:38:53
Message-ID: CACJufxFXJr61cxCBYBRhuU__S5YmdnGfHO8G2J7tYs0wbUODYQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 8, 2024 at 8:57 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
>
> Updated patch attached.
>

Returns true if the SQL/JSON <replaceable>path_expression</replaceable>
- applied to the <replaceable>context_item</replaceable> using the
- <literal>PASSING</literal> <replaceable>value</replaceable>s yields any
- items.
+ applied to the <replaceable>context_item</replaceable> doesn't yield
+ any items.
should "doesn't" be removed?
should it be "yields"?

+ set. The <literal>ON ERROR</literal> clause specifies the behavior
+ if an error occurs when evaluating
<replaceable>path_expression</replaceable>,
+ when coercing the result value to the
<literal>RETURNING</literal> type,
+ or when evaluating the <literal>ON EMPTY</literal> expression if the
+ <replaceable>path_expression</replaceable> evaluation results in an
+ empty set.
last sentence, "in an empty set." should be "is an empty set"

Other than that, it looks good to me.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Junwang Zhao 2024-07-09 01:44:00 Re: jsonpath: Inconsistency of timestamp_tz() Output
Previous Message Andy Fan 2024-07-09 01:18:11 Re: Parallel CREATE INDEX for GIN indexes