| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, alvherre(at)alvh(dot)no-ip(dot)org, Noah Misch <noah(at)leadboat(dot)com> |
| Subject: | Re: Statistics Import and Export |
| Date: | 2025-01-22 01:36:42 |
| Message-ID: | CACJufxFVQ-qWU4aU0KJDJeN1_5XEh3nhey5Vw2V5zazts7PL=A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
hi.
now stats_lock_check_privileges comments need to change?
* Lock relation in ShareUpdateExclusive mode, check privileges, and close the
* relation (but retain the lock).
since the above comments will not be true for RELKIND_INDEX.
Yes, there are comments within the function explaining the exception.
maybe we can incorporate the following
/*
* For indexes, we follow what do_analyze_rel() does so as to avoid any
* deadlocks with analyze/vacuum, which is to take out a
* ShareUpdateExclusive on table/matview first and only after that take
* a AccessShareLock on the index itself.
*/
comments into stats_lock_check_privileges comments section.
other than that, the patch fix looks good to me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2025-01-22 01:54:19 | RE: pgbench without dbname worked differently with psql and pg_dump |
| Previous Message | Andy Fan | 2025-01-22 01:14:22 | Re: Pre-allocating WAL files |