Re: Adding OLD/NEW support to RETURNING

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(at)vondra(dot)me>
Subject: Re: Adding OLD/NEW support to RETURNING
Date: 2024-08-21 09:06:49
Message-ID: CACJufxF2VbNX1N=tzUMx4NCfmtvT+dASM7Uo+dmjyj+YtOTrJQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 16, 2024 at 6:39 PM Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>

in Var comments:

* varlevelsup is greater than zero in Vars that represent outer references.
* Note that it affects the meaning of all of varno, varnullingrels, and
* varnosyn, all of which refer to the range table of that query level.

Does this need to change accordingly?

i found there is no privilege test in src/test/regress/sql/updatable_views.sql?
Do we need to add some tests?

Other than that, I didn't find any issue.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2024-08-21 09:28:25 Re: Cirrus CI for macOS branches 16 and 15 broken
Previous Message Peter Eisentraut 2024-08-21 09:04:57 Re: Cirrus CI for macOS branches 16 and 15 broken