| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
| Cc: | sawada(dot)mshk(at)gmail(dot)com, vignesh C <vignesh21(at)gmail(dot)com>, Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru>, Damir Belyalov <dam(dot)bel07(at)gmail(dot)com>, zhihuifan1213(at)163(dot)com, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, anisimow(dot)d(at)gmail(dot)com, HukuToc(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> |
| Subject: | Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features) |
| Date: | 2024-01-13 14:19:35 |
| Message-ID: | CACJufxEjYyhz3qSx0win6U4ZvJB7R5eWRSBau8oAyq3xsCknSA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 12, 2024 at 10:59 AM torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> wrote:
>
>
> Thanks for reviewing!
>
> Updated the patch merging your suggestions except below points:
>
> > + cstate->num_errors = 0;
>
> Since cstate is already initialized in below lines, this may be
> redundant.
>
> | /* Allocate workspace and zero all fields */
> | cstate = (CopyFromStateData *) palloc0(sizeof(CopyFromStateData));
>
>
> > + Assert(!cstate->escontext->details_wanted);
>
> I'm not sure this is necessary, considering we're going to add other
> options like 'table' and 'log', which need details_wanted soon.
>
>
> --
> Regards,
make save_error_to option cannot be used with COPY TO.
add redundant test, save_error_to with COPY TO test.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-minor-refactor.no-cfbot | application/octet-stream | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2024-01-13 14:36:11 | Re: Tidy fill hstv array (src/backend/access/heap/pruneheap.c) |
| Previous Message | Dmitry Dolgov | 2024-01-13 14:05:38 | Re: pg_stat_statements and "IN" conditions |