| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Joseph Koshakow <koshy44(at)gmail(dot)com> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Remove dependence on integer wrapping |
| Date: | 2024-07-23 06:14:14 |
| Message-ID: | CACJufxERqAgy4YBwc2hLZY=hw1kD2m6AVD3=kyAen8=HeLsfmw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 23, 2024 at 6:56 AM Joseph Koshakow <koshy44(at)gmail(dot)com> wrote:
>
> The specific bug that this patch fixes is preventing the following
> statement:
>
> # INSERT INTO arroverflowtest(i[-2147483648:2147483647]) VALUES ('{1}');
>
> So we may want to add that test back in.
>
I agree with you.
also v13-0003-Remove-dependence-on-integer-wrapping-for-jsonb.patch
in setPathArray we change to can
if (idx == PG_INT32_MIN || -idx > nelems)
{
/*
* If asked to keep elements position consistent, it's not allowed
* to prepend the array.
*/
if (op_type & JB_PATH_CONSISTENT_POSITION)
ereport(ERROR,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("path element at position %d is out of
range: %d",
level + 1, idx)));
idx = PG_INT32_MIN;
}
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2024-07-23 07:11:42 | Re: [18] Policy on IMMUTABLE functions and Unicode updates |
| Previous Message | kuroda.keisuke | 2024-07-23 06:02:07 | Re: Add privileges test for pg_stat_statements to improve coverage |