| From: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: Unit tests for SLRU |
| Date: | 2022-04-05 11:22:22 |
| Message-ID: | CACG=ezb4-Ai+AYfsi-6-9OG75zS7VMDNpG1BipY_+-5_GHM==Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> Again, I don't have a strong opinion here. If you insist, I will place the
> tests to regress.c.
>
It is up to committer to decide, but I think it would be good to place
tests in regression.
In my opinion, many things from core may be used by extensions. And then it
is up to extension authors to make relevant tests.
For me, it's enough to make a reasonable test coverage for SLRU without
investing too much effort into generalization.
--
Best regards,
Maxim Orlov.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2022-04-05 11:49:15 | Re: Window Function "Run Conditions" |
| Previous Message | gkokolatos | 2022-04-05 11:12:28 | Re: Add LZ4 compression in pg_dump |