| From: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Latches vs lwlock contention |
| Date: | 2024-09-10 16:53:02 |
| Message-ID: | CACG=ezYS6sKbWa=Py23jH8P-SXGbZ+z6T_rYaEwfjGfh_yLgrQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I looked at the patch set and found it quite useful.
The first 7 patches are just refactoring and may be committed separately if
needed.
There were minor problems: patch #5 don't want to apply clearly and the #8
is complained
about partitionLock is unused if we build without asserts. So, I add a
PG_USED_FOR_ASSERTS_ONLY
to solve the last issue.
Again, overall patch looks good and seems useful to me. Here is the rebased
v5 version based on Heikki's patch set above.
--
Best regards,
Maxim Orlov.
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0004-Move-TRACE-calls-into-WaitOnLock.patch | application/octet-stream | 2.5 KB |
| v5-0001-Remove-LOCK_PRINT-call-that-could-point-to-garbag.patch | application/octet-stream | 1.1 KB |
| v5-0003-Set-MyProc-heldLocks-in-ProcSleep.patch | application/octet-stream | 3.1 KB |
| v5-0005-Remove-redundant-lockAwaited-global-variable.patch | application/octet-stream | 5.3 KB |
| v5-0002-Fix-comment-in-LockReleaseAll-on-when-locallock-n.patch | application/octet-stream | 1.1 KB |
| v5-0007-Release-partition-lock-a-little-earlier.patch | application/octet-stream | 1.4 KB |
| v5-0006-Update-local-lock-table-in-ProcSleep-s-caller.patch | application/octet-stream | 2.1 KB |
| v5-0008-Split-ProcSleep-function-into-JoinWaitQueue-and-P.patch | application/octet-stream | 17.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2024-09-10 16:59:03 | Re: Refactoring postmaster's code to cleanup after child exit |
| Previous Message | Masahiko Sawada | 2024-09-10 16:52:42 | Re: First draft of PG 17 release notes |