Re: [Patch][pgAdmin4]: RM#1577 - Debug option for function/procedure under package node

From: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [Patch][pgAdmin4]: RM#1577 - Debug option for function/procedure under package node
Date: 2016-10-13 05:58:37
Message-ID: CACCA4P2RdQnS7c-tO+yk-MGqDa_diABUoLfvrJ_h7XYoNxDXvQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

On Fri, Oct 7, 2016 at 5:19 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Thanks, applied. Couple of questions/points:
>
> - If there is no body for a procedure, the error is handled somewhat
> ungracefully - the message is displayed without line breaks, and the
> debugger panel is left empty. Can we make that a little nicer?
>

OK, I will work on that.

>
> - In pgAdmin 3 there's a "Debug package initialiser?" option on the
> parameter dialogue. Is that shown for appropriate packages? I don't
> have an example to hand to test with.
>

Currently no option for "Debug package initialiser".

I will submit updated patch for both above points.

>
> On Fri, Oct 7, 2016 at 11:55 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
> wrote:
> > Hi,
> >
> > Please find attached patch file which contains function/procedure debug
> > support under package node. (RM #1577)
> >
> > Do review it and let me know for any comments.
> >
> > Thanks,
> > Neel Patel
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Priyanka Shendge 2016-10-13 06:15:42 Re: Foreign Table Patch
Previous Message Dave Page 2016-10-12 14:06:20 Re: [PATCH] Document that a patch should be submitted to the list as an attachment