From: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Nikolai Zhubr <n-a-zhubr(at)yandex(dot)ru>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390 |
Date: | 2016-01-05 12:24:06 |
Message-ID: | CACCA4P1Rm1Z1em+XMO5qy3Ne=ckyMMbUeffsNKPWti1z7Abziw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
Please find attached patch file with below fix.
- Return value of the function will be displayed as "SETOF record" instead
of "SETOF SETOF record" under SQL tab within properties window.
Let me know for any comments.
Thanks,
Neel Patel
On Tue, Jan 5, 2016 at 5:08 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
wrote:
> Hi Dave,
>
> Sure, I will look into this issue.
>
> Thanks,
> Neel Patel
>
> On Tue, Jan 5, 2016 at 4:47 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Neel, can you look at this please?
>>
>> Thanks.
>>
>> On Tue, Jan 5, 2016 at 11:01 AM, Nikolai Zhubr <n-a-zhubr(at)yandex(dot)ru>
>> wrote:
>> > Hi all,
>> >
>> > Running 1.22-rc1 now I observe that this commit has apparently still not
>> > solved the issue in at least one place. That is:
>> >
>> > - "RETURNS SETOF record" is correctly displayed in SQL panel now.
>> >
>> > - "RETURNS SETOF SETOF record" is still erroneously displayed under SQL
>> tab
>> > within the properties window (effectively preventing set-returning
>> function
>> > to be changed in any way through the properties window).
>> >
>> >
>> > Thank you,
>> > Nikolai
>> >
>> > 12.10.2015 5:33, Ashesh Vashi:
>> >>
>> >> As per commit:600daf650bd5e50e664c4ece2e53e95446390b6d, we now use
>> >> pg_get_function_result(..) function to identify the return type of the
>> >> function, hence - we don't need to add SETOF keyword explicitly, when a
>> >> function returns set of records.
>> >>
>> >> Branch
>> >> ------
>> >> master
>> >>
>> >> Details
>> >> -------
>> >>
>> >>
>> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9d7596dc552cf9315d4aa83eafe19db1acf7e531
>> >>
>> >> Modified Files
>> >> --------------
>> >> pgadmin/schema/pgFunction.cpp | 2 --
>> >> 1 file changed, 2 deletions(-)
>> >>
>> >>
>> >
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
Attachment | Content-Type | Size |
---|---|---|
function_sql_setof.patch | application/octet-stream | 432 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2016-01-05 13:55:21 | PATCH: Minor patch to fix 'qtLiteral' function in pgAdmin4 |
Previous Message | Neel Patel | 2016-01-05 11:38:08 | Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390 |