[Patch][pgAdmin4][runtime]: RM#1375 - Migrate the runtime to QtWebEngine from QtWebKit

From: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [Patch][pgAdmin4][runtime]: RM#1375 - Migrate the runtime to QtWebEngine from QtWebKit
Date: 2016-11-04 10:35:04
Message-ID: CACCA4P18f7=57mrr3bgfYwGavdUkNfVDTem5AvQHum--sLpznw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please find attached initial patch for migration of runtime to QtWebEngine
from QtWebkit.

*Observation:-*

When user click on already opened link, it will not set existing tab index
but always open in new tab.
e.g. pgAdmin4 website is already open in new tab and user again open the
same website then it will not set existing tab index but always open in new
tab.

First "createWindow" virtual protected method is getting called which does
not contain any URL of page but it will create WebEnginePage for the
WebEngineView.
Once the WebEnginePage is created in above method, we are getting
"acceptNavigationRequested" call which contains URL so before we save the
URL, tab was already opened so we are not able to compare with existing
opened tab.

I have tested this patch on Linux & Mac and it is working as expected.

Do review it and let us know for any comments.

Thanks,
Neel Patel

Attachment Content-Type Size
RM_1375_qwebengine_v1.patch application/octet-stream 19.1 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Susan Douglas 2016-11-04 11:37:18 Re: no search box on query tool toolbar
Previous Message Dave Page 2016-11-04 09:21:29 Re: no search box on query tool toolbar