Re: [PGAGENT] [PATCH] Remove wxWidget dependency

Hi Ashesh,

I have verified this in windows 10 and found existing below compilation
issues with Visual Studio compiler ( MSVC 14 ).

2>C:\Projects\pgagent\misc.cpp(167): warning C4244: 'argument': conversion
from 'time_t' to 'unsigned int', possible loss of data
2>C:\Projects\pgagent\misc.cpp(168): error C2131: expression did not
evaluate to a constant
2> C:\Projects\pgagent\misc.cpp(168): note: failure was caused by
non-constant arguments or reference to a non-constant symbol
2> C:\Projects\pgagent\misc.cpp(168): note: see usage of 'length'
2>C:\Projects\pgagent\misc.cpp(169): error C3863: array type 'char
[length]' is not assignable
2>C:\Projects\pgagent\misc.cpp(184): error C3863: array type 'char
[length]' is not assignable

Below are the changes to fix the compilation issues.

​

I have tested attached patch and it is working fine in windows. Please find
attached modified patch with the fix.
Do review it and let us know for any comments.

Thanks,
Neel Patel

On Mon, May 7, 2018 at 12:50 PM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:

> Hi Dave/Team,
>
> Please find the attached patch to remove the wxWidgets dependency, and
> added "Boost" dependency from the pgAgent code.
>
> The original author of the patch is Neel Patel.
>
> I have modified couple of things like:
> - Using Locker class to work locking & unlocking of shared mutex always in
> tandem
> - Using single pointer handler class for handling the memory leak of
> DBresult class
>
> Please review it, and let us know the concerns.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>