Re: [pgAdmin4]: Fix for RM #3248

From: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4]: Fix for RM #3248
Date: 2018-04-05 06:02:39
Message-ID: CACCA4P1+4ww+reLX8J_bGuOGindbAyMX4A7wKVJi_04BsLN-bg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks Murtuza & Khushboo.
I will send updated patch.

Thanks,
Neel Patel

On Thu, Apr 5, 2018 at 11:29 AM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Neel,
>
> Add below code to the top (around line no 8) in
> alertify.pgadmin.defaults.js file will solve the problem.
>
> alertify.defaults.closable = false;
>
>
> Thanks,
> Khushboo
>
> On Thu, Apr 5, 2018 at 11:13 AM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi Neel,
>>
>> Can we make the change in wrapper instead of changing every where?
>> File: ../web/pgadmin/static/js/alertify.pgadmin.defaults.js
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Thu, Apr 5, 2018 at 11:04 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
>> wrote:
>>
>>> Hi,
>>>
>>> Please find attached patch for the fix of RM #3248 - we have modified
>>> alertify confirm dialog to modal dialog.
>>>
>>> Do review it and let me know for comments.
>>>
>>> Thanks,
>>> Neel Patel
>>>
>>
>>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Neel Patel 2018-04-05 06:49:43 Re: [pgAdmin4]: Fix for RM #3248
Previous Message Khushboo Vashi 2018-04-05 05:59:14 Re: [pgAdmin4]: Fix for RM #3248