Re: pgAdmin 4 commit: Fix a number of broken connection detection scenarios

From: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin 4 commit: Fix a number of broken connection detection scenarios
Date: 2018-04-05 05:22:10
Message-ID: CACCA4P0TS39JP8-MQdTq5Nmz=4MprG3gbZZGR5_u5O8ML82P7A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Akshay,

Due to above commit, when user "Drop" any database it gives exception in
browser console.
Check attached screenshot.

Thanks,
Neel Patel

On Wed, Mar 21, 2018 at 2:08 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Fix a number of broken connection detection scenarios.
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> 637f3b9d1a54df8b9a1bfad9e26f27fdea407683
> Author: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
>
> Modified Files
> --------------
> web/pgadmin/dashboard/static/js/dashboard.js | 58
> ++++++++++++--------
> web/pgadmin/static/js/sqleditor/execute_query.js | 62
> +++++++++++----------
> .../js/sqleditor/is_new_transaction_required.js | 9 ++++
> web/pgadmin/tools/sqleditor/__init__.py | 4 +-
> web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 20 ++++---
> .../tools/sqleditor/tests/test_start_query_tool.py | 2 +-
> .../tools/sqleditor/utils/start_running_query.py | 63
> ++++++++++------------
> .../utils/tests/test_start_running_query.py | 15 +++++-
> .../user_management/static/js/user_management.js | 13 ++++-
> .../utils/driver/psycopg2/server_manager.py | 1 +
> .../javascript/sqleditor/execute_query_spec.js | 48 ++++++++++++-----
> .../sqleditor/is_new_transaction_required_spec.js | 14 ++---
> 12 files changed, 195 insertions(+), 114 deletions(-)
>
>

Attachment Content-Type Size
db_drop_error.png image/png 316.4 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Neel Patel 2018-04-05 05:34:30 [pgAdmin4]: Fix for RM #3248
Previous Message Khushboo Vashi 2018-04-05 03:35:40 Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree