[pgAdmin4][runtime][patch]: RM#2398 - Proxy not bypassed for embedded server in runtime on Windows

From: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][runtime][patch]: RM#2398 - Proxy not bypassed for embedded server in runtime on Windows
Date: 2017-05-18 14:42:17
Message-ID: CACCA4P0KyPQj=Q4EieTvs1JH=LTkvjHOTEZytbu-CFB+_L5zbQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

Please find attached patch for the fix of RM#2398 - "Proxy not bypassed for
embedded server in runtime on Windows".

*Observation:-*
We have observed this issue only with Qt WebEngine. We have not observed
this issue with Webkit ( Tested with Qt 5.3 ).

*Issue:-*
If user set option "Bypass proxy server for local addresses" then WebEngine
doesn't bypass the request for local addresses even if that option is set.

*Solution:-*
Now if user set option "Bypass proxy server for local addresses" then Web
Engine bypass the request for localhost and if user unset then request will
not be bypassed.

Please find attached fix for this issue. Do review and test it and let me
know for any issue.

Thanks,
Neel Patel

Attachment Content-Type Size
RM_2398.patch application/octet-stream 676 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Joao Pedro De Almeida Pereira 2017-05-18 14:52:46 Re: [pgAdmin4][PATCH] To fix the issue with Node rename
Previous Message Joao Pedro De Almeida Pereira 2017-05-18 14:27:40 Re: Fix for RM2421 [pgAdmin4][patch]