From: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool |
Date: | 2017-11-16 13:31:40 |
Message-ID: | CACCA4P03pGGvjWDZN_cbPgepwtGRHMHQce4O80gX_5esFM8sRA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
I am able to reproduce the crash while downloading and save data in CSV
file from query tool.
Please find attached updated patch with below changes after reading Qt
documentation.
- Added new signal "readyRead". As per the Qt documentation, this signal
will be emitted when data is ready from IO channel for large amount of data
transfer between server and client.
- Ready read and DownloadInProgress signal is very quick in call so we
should not do large operation inside that slot because for downloading big
data it may possible of frequent call of those signals which may cause the
crash or missing data to write inside the file so removed unnecessary logic
from that slot.
- Fixed the crash while opening IODevice with NULL handle.
With above changes, I have tested with same data as earlier and it is
working as expected without crashing the application.
Do review it and let me know for comments.
Thanks,
Neel Patel
Attachment | Content-Type | Size |
---|---|---|
RM_2829_RM_2491.patch | application/octet-stream | 9.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Neel Patel | 2017-11-16 13:47:24 | Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool |
Previous Message | Dave Page | 2017-11-16 13:28:59 | Re: Next release |