Re: Patch: Implement failover on libpq connect level.

From: "Shulgin, Oleksandr" <oleksandr(dot)shulgin(at)zalando(dot)de>
To: Christopher Browne <cbbrowne(at)gmail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL Mailing Lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: Implement failover on libpq connect level.
Date: 2015-10-27 08:42:56
Message-ID: CACACo5Sno_rvor892t-rxVtA+19VYXZD1JR=8_orWm-6-0xKCQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-jdbc

On Mon, Oct 26, 2015 at 10:02 PM, Christopher Browne <cbbrowne(at)gmail(dot)com>
wrote:

>
> On 26 October 2015 at 16:25, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>
>> On 10/14/15 6:41 AM, Victor Wagner wrote:
>> > 1. It is allowed to specify several hosts in the connect string, either
>> > in URL-style (separated by comma) or in param=value form (several host
>> > parameters).
>>
>> I'm not fond of having URLs that are not valid URLs according to the
>> applicable standards. Because then they can't be parsed or composed by
>> standard libraries.
>>
>> Also, this assumes that all the components other than host and port are
>> the same. Earlier there was a discussion about why the ports would ever
>> need to be different. Well, why can't the database names be different?
>> I could have use for that.
>>
>> I think you should just accept multiple URLs.
>>
>
> I'd give a "+1" on this...
>
> As an area of new behaviour, I don't see a big problem with declining to
> support every wee bit of libpq configuration, and instead requiring the
> use of URLs.
>
> Trying to put "multiplicities" into each parameter (and then considering
> it at the pg_service level, too) is WAY more complicated, and for a
> feature where it seems to me that it is pretty reasonable to have a
> series of fully qualified URLs.
>
> Specifying several URLs should be easier to understand, easier to
> test, easier to code, and easier to keep from blowing up badly.
>

Setting aside all other concerns, have a +1 from me on that too.

--
Alex

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message rajan 2015-10-27 10:25:31 Disabling START TRANSACTION for a SuperUser
Previous Message Pavel Stehule 2015-10-27 08:34:00 Re: proposal: PL/Pythonu - function ereport

Browse pgsql-jdbc by date

  From Date Subject
Next Message Stefan M 2015-10-27 08:50:28 Re: JDBC Version 1204 breaks OpenOffice/LibreOffice handling of database table views up to version 1203
Previous Message Christopher Browne 2015-10-26 21:02:17 Re: Patch: Implement failover on libpq connect level.