Re: On-demand running query plans using auto_explain and signals

From: "Shulgin, Oleksandr" <oleksandr(dot)shulgin(at)zalando(dot)de>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: On-demand running query plans using auto_explain and signals
Date: 2015-09-09 09:54:44
Message-ID: CACACo5RowbRffGTn=JazPmBkMkmDoCwH7EJgO9F1gCCLPEW3eg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 9, 2015 at 10:22 AM, Shulgin, Oleksandr <
oleksandr(dot)shulgin(at)zalando(dot)de> wrote:

> On Wed, Sep 9, 2015 at 8:36 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
> wrote:
>
>>
>>> Please find attached v4.
>>>
>>
>> It is better
>>
>
> One important thing to notice, and probably deserves a code comment, that
> any modification of the slot fields done by the info sender backend must be
> done before actually sending the message via the shared memory queue (or
> detaching one, if there's nothing to be sent). Otherwise it is possible
> that is_processed flag will be set on the slot that has been already reused
> by the receiving backend.
>

Sorry, the latest version did contain some debugging messages I didn't
intend to send. I've removed them and also added a comment about the above
synchronization problem.

--
Alex

Attachment Content-Type Size
explain-pid-v4.1.patch text/x-patch 22.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2015-09-09 10:08:30 Re: Minor code improvements to create_foreignscan_plan/ExecInitForeignScan
Previous Message Fabien COELHO 2015-09-09 09:01:35 Re: checkpointer continuous flushing