From: | Matthias Kuhn <matthias(at)opengis(dot)ch> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Build versionless .so for Android |
Date: | 2024-01-05 00:00:05 |
Message-ID: | CAC7zN96eLBzb_pxpBK3L3+_5wg0p_VJF3wsq88ZCDEPEbtwK+A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
Attached a patch with a (hopefully) better wording of the comment.
I have unsuccessfully tried to find an official source for this policy.
So for reference some discussions about the topic:
-
https://stackoverflow.com/questions/11491065/linking-with-versioned-shared-library-in-android-ndk
-
https://stackoverflow.com/questions/18681401/how-can-i-remove-all-versioning-information-from-shared-object-files
Please let me know if I can help in any way
Matthias
On Tue, Jan 2, 2024 at 6:43 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Sun, Dec 31, 2023 at 1:24 AM Michael Paquier <michael(at)paquier(dot)xyz>
> wrote:
> > FWIW, I have mixed feelings about patching the code to treat
> > android-linux as an exception while changing nothing in the
> > documentation to explain why this is required. A custom patch may
> > serve you better here, and note that you did not even touch the meson
> > paths. See libpq_c_args in src/interfaces/libpq/meson.build as one
> > example. That's just my opinion, of course, still there are no
> > buildfarm members that would cover your patch.
>
> It's reasonable to want good comments -- the one in the patch (1)
> doesn't explain why this is required and (2) suggests that it is only
> needed when cross-compiling which seems surprising and (3) has a typo.
> But if it's true that this is needed, I tentatively think we might do
> better to take the patch than force people to carry it out of tree.
>
> --
> Robert Haas
> EDB: http://www.enterprisedb.com
>
Attachment | Content-Type | Size |
---|---|---|
versionless_2.patch | text/x-patch | 1.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Davis | 2024-01-05 00:56:11 | Re: [17] CREATE SUBSCRIPTION ... SERVER |
Previous Message | Michael Paquier | 2024-01-04 23:48:33 | Re: Add a perl function in Cluster.pm to generate WAL |