Re: Behavior of recovery_target_inclusive.

Hi Michael

Thanks for your reply and quick reaction.

2017-10-23 23:05 GMT+09:00 Michael Paquier <michael(dot)paquier(at)gmail(dot)com>:

> On Mon, Oct 23, 2017 at 10:27 PM, <t(dot)katsumata1122(at)gmail(dot)com> wrote:
> > At &quot;recovery_target_inclusive (boolean)&quot;, nothing is
> mentioned about
> > &quot;recovery_target_lsn&quot;.
> > It should be fixed, since &quot;recovery_target_lsn&quot; is affected
> by the value of
> > &quot;recovery_target_inclusive&quot;.
> >
> > Could you check this?
>
> Apologies. You are right, this is a documentation bug and should be
> fixed. Attached is a patch to address the problem. The trend on the
> documentation page for recovery parameters is to list the options
> alphabetically, so recovery_target_lsn comes first.
> --
> Michael
>

Your patch seems good, but I have a question.
Does it need to fix the next sentence?
Like this:
----
This setting controls whether transactions having exactly the target WAL
location (LSN), commit time or ID, respectively, will be included in the
recovery.
----

Best regards,